Skip to content

Set height on nested elements to avoid mutliple scrollbars#207

Open
fleaz wants to merge 1 commit into
tilfinltd:mainfrom
codemonauts:fix/multiple_scrollbars
Open

Set height on nested elements to avoid mutliple scrollbars#207
fleaz wants to merge 1 commit into
tilfinltd:mainfrom
codemonauts:fix/multiple_scrollbars

Conversation

@fleaz

@fleaz fleaz commented Jul 20, 2021

Copy link
Copy Markdown

Hey,

even with the latest version I was still struggling with #180 even on different screens and resolutions so I decided to create a small PR to make this awesome extension a tiny bit better :)

Best,
Felix

Before

After

@tilfin

tilfin commented Jul 20, 2021

Copy link
Copy Markdown
Member

@fleaz Could you tell me your OS and browser, screen scaling percent?

@fleaz

fleaz commented Jul 20, 2021

Copy link
Copy Markdown
Author

OS: Arch Linux
Browser: Chromium 91
Screen: 4K
Scaling: Between 1,3x and 1,5x

tilfin
tilfin reviewed Jul 25, 2021
View reviewed changes
Comment thread popup.html Outdated
@tilfin

tilfin commented Jul 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@fleaz I didn't reproduce this situation in my environment.

Scaling: Between 1,3x and 1,5x

Can you tell me how to set this up?

@fleaz

fleaz commented Jul 26, 2021

Copy link
Copy Markdown
Author

I just talked to a colleague of mine who also uses this plugin and also has this issue and we found the root cause of this :)

This happens when you go to Settings -> Apperance and configure a Page Zoom higher than 100% (Mine was e.g. on 125% because I run a highDPI display and want things to be a bit bigger). In contrast to the normal zooming on a website with Ctrl+ +/- which only changes the page ocntent, the PageZoom you configure in the settings also has an effect on your browser extensions which causes the double scrollbar issue.

@tilfin

tilfin commented Aug 7, 2021

Copy link
Copy Markdown
Member

@fleaz Thank you, I could recoginize it.

@fleaz fleaz force-pushed the fix/multiple_scrollbars branch from 79d7df1 to 8a90adc Compare August 9, 2021 08:53
@tilfin

tilfin commented Aug 15, 2021

Copy link
Copy Markdown
Member

Hmm, the height is not automatically expanded in my Windows environment.
image

@tilfin tilfin force-pushed the main branch 2 times, most recently from b58bfb3 to 9a7ceff Compare January 17, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tilfin tilfin tilfin left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fleaz @tilfin